Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why own implementation jwt? #4

Open
marcrib opened this issue Dec 20, 2018 · 3 comments
Open

Why own implementation jwt? #4

marcrib opened this issue Dec 20, 2018 · 3 comments

Comments

@marcrib
Copy link

marcrib commented Dec 20, 2018

Why not use IdentityServer or OpenIdDict? Which are most complete and tested frameworks

You use ROPC

I recently read that ROPC may have several security holes, this link addresses some of them:
https://tools.ietf.org/html/rfc6749#section-10.7

brute force, save password in client log, others ...

What is your opinion about this?

@spetz
Copy link
Member

spetz commented Dec 20, 2018

We didn't use Identity Server or other similar solution, simply, because we wanted to show the end users how the JWT works under the hood and that it could be easily implemented.

Our code uses well-tested system libraries, so, there's no real threat or bugs AFAIK. The password is being hashed using one way PBKDF2 etc. - so basically, it's almost impossible to do a brute force if your password is strong enough. Our code doesn't save a password in any logs.

IdentityServer is a great solution, and it might be a part of the next release of ASP.NET Core, but, we didn't want the programmers who explore the code, to get familiar with another quite sophisticated library.

At some point in the future, there's a chance, that we will create a new service using one of the solutions that you suggested.

@marcrib
Copy link
Author

marcrib commented Dec 20, 2018

@spetz thanks

great solution

@spetz
Copy link
Member

spetz commented Dec 20, 2018

I'm happy to hear that my answer was clear enough :).
Most of the utilities that we use are our wrappers on top of existing libraries - to keep the overall solution simple and cloud agnostic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants