Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Jaeger broke the Identity Service and prevents the customer from signing up #5

Open
bravecobra opened this issue Feb 19, 2019 · 1 comment

Comments

@bravecobra
Copy link

After introducing Jaeger, the call POST {{identityServiceUrl}}/sign-up broke. Or any API call for that matter that is being passed an empty CorrelationContext.
The empty Correlation context is being handled properly in the API gateway, but calls to the IdentityService do no pass the API gateway and in the IdentityService an empty CorrelationContext is not handled properly (and it does not contain a SpanContext that can be send to Jaeger). It throws an exception in the Jaeger middleware.

To fix this, the IdentityService needs to handle empty CorrelationContext's properly. We could borrow the methods from BaseController of the API gateway.
Then, the event, sent from the IdentityService class, also needs that new properly handled CorrelationContext, in order to pass it on when publishing the event.

@GooRiOn
Copy link
Member

GooRiOn commented Feb 19, 2019

Hi, thx for the comment! We actually noticed that recently. Therefore some fix will be published soon (possibly tommorow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants