Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't get friends.js from outside of src #3

Closed
asBrettisay opened this issue Feb 8, 2017 · 5 comments
Closed

Can't get friends.js from outside of src #3

asBrettisay opened this issue Feb 8, 2017 · 5 comments

Comments

@asBrettisay
Copy link
Contributor

CRA only supports babelizing from inside of src.
@r-walsh
Copy link
Contributor

r-walsh commented Feb 8, 2017

@asBrettisay Really? I'm not very familiar with CRA, but they're using Webpack so it shouldn't matter where the file came from. Is it a config thing or a convention thing?

@asBrettisay
Copy link
Contributor Author

asBrettisay commented Feb 8, 2017 •
edited

@r-walsh Check out this issue from CRA

@r-walsh
Copy link
Contributor

r-walsh commented Feb 8, 2017

Weird, at least it's an easy fix on our end.

@asBrettisay
Copy link
Contributor Author

I would have fixed it without making an issue, but I was in class and I didn't want to forget

@asBrettisay
Copy link
Contributor Author

Fixed by #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@r-walsh @asBrettisay