Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation errors #13

Merged
merged 2 commits into from Jul 7, 2022
Merged

Conversation

olof-nord
Copy link
Contributor

@olof-nord olof-nord commented Jun 22, 2022

Fix compilation errors in the main and lib/shared/informationDialogs files.

Without these adjustments, the project does not build on my local machine.

➜  cockpit_open_frontend git:(develop) ✗ flutter run -d linux      
Launching lib/main.dart on Linux in debug mode...
ERROR: lib/main.dart:301:22: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
ERROR:  - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/opt/flutter/packages/flutter/lib/src/widgets/binding.dart').
ERROR:       WidgetsBinding.instance!.addPostFrameCallback((_) {
ERROR:                      ^
ERROR: lib/shared/informationDialogs.dart:896:23: Error: Expected ',' before this.
ERROR:                       Row(
ERROR:                       ^^^
ERROR: ../../.pub-cache/hosted/pub.dartlang.org/provider-5.0.0/lib/src/inherited_provider.dart:391:26: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
ERROR:  - 'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('/opt/flutter/packages/flutter/lib/src/scheduler/binding.dart').
ERROR:         SchedulerBinding.instance!.addPostFrameCallback((_) {
ERROR:                          ^
Building Linux application...                                           
Exception: Build process failed

Additionally, the automatically updated files following executing flutter pub upgrade are also added.

@olof-nord
Copy link
Contributor Author

olof-nord commented Jun 22, 2022

I would say @julienAhn, this is quite a risk-free change.

My flutter specifics:

➜  cockpit_open_frontend git:(fix-build-errors) flutter --version
Flutter 3.0.1 • channel stable • https://github.com/flutter/flutter.git
Framework • revision fb57da5f94 (5 weeks ago) • 2022-05-19 15:50:29 -0700
Engine • revision caaafc5604
Tools • Dart 2.17.1 • DevTools 2.12.2

@julienAhn
Copy link
Collaborator

Great! Thank you for continuing to participate in the improvement of the desktop app.

@julienAhn julienAhn merged commit 5510cb2 into devolo:develop Jul 7, 2022
@olof-nord olof-nord deleted the fix-build-errors branch July 26, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants