Add vscode devcontainer #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienAhn
requested changes
Jun 4, 2021
There was a problem hiding this comment.
Hey, first of all thanks for your contribution. I would like to merge your merge request but a few things have to be done before.
- As we are developing since a while on the develop branch, I want you to do the merge request towards the develop branch.
- The README needs to explain shortly that we are offering this devcontainer. I would suggest to add at the bottom of the "Building and Running the App" section following text: "For Visual Studio Code and Linux users we provide a devcontainer.json file which allows you to start developing inside a container. (https://code.visualstudio.com/docs/remote/containers)
For using the development container you need the devolo Cockpit application from https://www.devolo.de/support/downloads/download/devolo-cockpit on your host system and you need to run 'xhost +local:' if you want to see the UI while debugging.
|
Hi @julienAhn , I added the requested paragraph to the readme and changed the base branch. |
julienAhn
approved these changes
Jun 4, 2021
|
@Shutgun Somehow he complained about rebase conflicts. I checked it locally, "resolved the conflicts" and pushed it on a new branch and merged it into the develop branch. Your changes are now in the repository. I will close this merge request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Visual Studio code supports an easy start in development using devcontainer. They come will all the packages that I need to start development right away.
The devcontainer was developed and tested on Linux, other OS still need some love.
This devcontainer requires two things: you need to start the devolonetsvc on the host system to see devices and you need to run 'xhost +local:' if you want to see the UI while debugging.