Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow #8

Closed
wants to merge 7 commits into from

Conversation

olof-nord
Copy link
Contributor

Looking at the repo, as there is a gitlab CI file, I am guessing somewhere a pipeline is executed.

As to also automatically test GitHub pull requests, one idea would be to add a GitHub Workflow which does the same as the GitLab CI.

This PR is implementing a GitHub Workflow which does roughly the same as the GitLab CI automation.

@Shutgun
Copy link
Member

Shutgun commented Feb 3, 2022

Hi @olof-nord , it looks like the tests are executed twice. Same in the gitlab CI by the way. Do you see a chance to combine both flutter test calls?

@olof-nord
Copy link
Contributor Author

Hello @Shutgun, very good question.

I do not have much experience with flutter, but it seems that the two test commands differ slightly, the second one is testing the lib part of the application, the first one the whole project.

Feel free to use this branch as a starting point for further exploration/research.

@Shutgun Shutgun mentioned this pull request Feb 3, 2022
@julienAhn
Copy link
Collaborator

Hey @olof-nord @Shutgun, both test calls are executing all created unit-tests in our project. I think the reason why we seperated them is that both arguments "--machine" and "--coverage" didn´t worked together. As we don´t really need a json output file I´m fine to not use the "--machine" argument and to have only one test call. I will merge #9 and close this one.

@julienAhn julienAhn closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants