Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include license texts in persisted datamodel json file #160

Closed
ohecker opened this issue Feb 2, 2023 · 1 comment · Fixed by #161
Closed

Include license texts in persisted datamodel json file #160

ohecker opened this issue Feb 2, 2023 · 1 comment · Fixed by #161
Assignees
Labels
enhancement New feature or request

Comments

@ohecker
Copy link
Member

ohecker commented Feb 2, 2023

As a user of Solicitor I want to make sure that I can reproduce Solicitor report results completely by regenerating the reports based on a previously stored data model json. This is currently limited by the fact that license texts are not stored in the data model json but are always (re-)fetched based on their URL.
The content fetched via URL is stored/cached locally in the filesystem. So to safely reproduce reports it is currently necessary to not only save the data model json but to also archive this file cache.

License texts should be included in the data model json to only require this to be archived.

@ohecker ohecker added the enhancement New feature or request label Feb 2, 2023
@ohecker ohecker self-assigned this Feb 2, 2023
@ohecker
Copy link
Member Author

ohecker commented Feb 2, 2023

Implementation should avoid excessive file sizes of the data model json by ensuring that identical license texts are stored only once in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant