Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScancodeFileAdapter needs refactoring #191

Closed
ohecker opened this issue Aug 8, 2023 · 0 comments · Fixed by #193
Closed

ScancodeFileAdapter needs refactoring #191

ohecker opened this issue Aug 8, 2023 · 0 comments · Fixed by #193
Labels
enhancement New feature or request

Comments

@ohecker
Copy link
Member

ohecker commented Aug 8, 2023

The ScancodeFileAdapter (part of the experimental integration with Scancode) requires a refactoring: Currently it comprises the following functionality within a single class:

  • Loading the Scancode data from the filesystem
  • Parsing and transforming the data to the ComponentInfo datastructure (where transforming contains a lot of heuristic business code)
  • Loading the Curation data from the filesystem
  • Parsing the curation data and applying it to the ComponentInfo data structure

This should be separated into different classes/beans to separate the different aspects. Specifically it should be possible to easier change the technical persistence layer (currently file system) from the business logic.

@ohecker ohecker added the enhancement New feature or request label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant