simple constructor for the untyped registers exposed

luraproject · Apr 8, 2018 · 94033b2 · 94033b2
1 parent b4f454b
commit 94033b2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/register/internal/untyped_go19.go b/register/internal/untyped_go19.go
@@ -4,8 +4,14 @@ package internal
 
 import "sync"
 
+func NewUntyped() *Untyped {
+	return &Untyped{
+		data: &sync.Map{},
+	}
+}
+
 type Untyped struct {
-	data sync.Map
+	data *sync.Map
 }
 
 func (u *Untyped) Register(name string, v interface{}) {

diff --git a/register/internal/untyped_other.go b/register/internal/untyped_other.go
@@ -4,6 +4,13 @@ package internal
 
 import "sync"
 
+func NewUntyped() *Untyped {
+	return &Untyped{
+		data:  map[string]interface{}{},
+		mutex: &sync.RWMutex{},
+	}
+}
+
 type Untyped struct {
 	data  map[string]interface{}
 	mutex *sync.RWMutex

diff --git a/register/register.go b/register/register.go
@@ -30,14 +30,14 @@ func (n *Namespaced) Register(namespace, name string, v interface{}) {
 	if r, ok := n.data[namespace]; ok {
 		r.Register(name, v)
 	} else {
-		n.data[namespace] = new(internal.Untyped)
+		n.data[namespace] = internal.NewUntyped()
 		n.data[namespace].Register(name, v)
 	}
 	n.mutex.Unlock()
 }
 
 func (n *Namespaced) AddNamespace(namespace string) {
 	n.mutex.Lock()
-	n.data[namespace] = new(internal.Untyped)
+	n.data[namespace] = internal.NewUntyped()
 	n.mutex.Unlock()
 }