Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or remove es6-promise dependency #188

Closed
justinhoward opened this issue Jul 12, 2019 · 1 comment · Fixed by #189
Closed

Update or remove es6-promise dependency #188

justinhoward opened this issue Jul 12, 2019 · 1 comment · Fixed by #189

Comments

@justinhoward
Copy link
Contributor

Currently es6-promise is listed as a dependency and restricted to ^3.1.2 in package.json. That prevents updating to version 4.0.0 or higher. I see two solutions:

  • Update the dependency to >=3.1.2 <5.0.0 to allow the newest version
  • Remove the dependency on es6-promise and rely on developers to choose their own polyfill if necessary.

The first is easiest and that might be a good quick fix. I'm guessing that the long-term solution is to remove the dependency and polyfill altogether. This would allow developers to choose their own polyfill or no polyfill at all.

@Auspicus
Copy link
Collaborator

I'm ok with us just updating the dependency for now. Do you want to get a PR up with that change? @justinhoward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants