Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature (HomeViewModel): Make ViewModel class #36

Conversation

PaoloProdossimoLopes
Copy link
Contributor

@PaoloProdossimoLopes PaoloProdossimoLopes commented Apr 28, 2022

馃摑 DESCRIPTION:

  • Add Service calls in ViewModel
  • Add Published properties in ViewModel to notify View
  • Add Add ViewModel as StateObject

馃敆 ASSOCIATED DOCUMENTATION:聽

Figma Prototype

馃搱 UNIT TESTS:

There was some change?

  • NO
  • YES, which?:

There was some addition?

  • NO
  • YES, which?:聽

馃摝 DEPENDENCY:

Some dependencies are added ?

  • NO聽
  • YES, which?:聽聽

Some dependencies are changed ?

  • NO聽
  • YES, which?:聽聽

馃摚 ACCESSIBILITY

Has there been any change in accessibility ?

  • NO
  • YES, which?:聽

Add some accessibility feature ?

  • NO
  • YES, which?:聽

馃柤 EVIDENCY

  • NO
  • YES, check below:

馃搷 HOW TO TEST:

FLUX:聽BUILD APP
VARIABLES: At moment does not possible to test, because It's needs to implement at HomeView or LaunchView
BRANCH: paolo/feature/nextLaunchAPI

鈽戯笍 CHECK LIST DEV:

  • Have I revised the code?
  • Am I up to date with develop?
  • Removed the prints?
  • Does my code follow the style of the project?
  • Didn't my changes generate warnings?
  • Have my layouts been validated on smaller screens?
  • Have my layouts been validated on larger screens?
  • I didn't add duplicate code!
  • Does not contain loose numbers (magic numbers)聽
  • Does not contain loose texts聽
  • Respects the naming standard
  • I didn't leave any callbacks with strong references!
  • I didn't add 'Force unwrap' (!)
  • Is the code following the default language defined for project development?
  • The tests are covering >= 70%聽(if not possible now you can ckecked)
  • My code was reviewed by at least 2 developers

Description:
- Add Service calls in ViewModel
- Add Published properties in ViewModel to notify View
- Add Add ViewModel as StateObject
@PaoloProdossimoLopes PaoloProdossimoLopes marked this pull request as draft April 28, 2022 17:39
@PaoloProdossimoLopes PaoloProdossimoLopes changed the title [WIP] Feature (HomeViewModel): Make ViewModel class Feature (HomeViewModel): Make ViewModel class Apr 28, 2022
@PaoloProdossimoLopes PaoloProdossimoLopes marked this pull request as ready for review April 29, 2022 02:03
@faganello60 faganello60 merged commit 989c811 into devpass-tech:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants