Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ViewCode-MD] - LoadingView component with custom message #5

Merged
merged 11 commits into from Feb 24, 2022
Merged

[ViewCode-MD] - LoadingView component with custom message #5

merged 11 commits into from Feb 24, 2022

Conversation

HyagoHenrique
Copy link
Contributor

@HyagoHenrique HyagoHenrique commented Feb 22, 2022 •
edited

Descrição e Solução

  • Implementado o componente de loading (LoadingView) com mensagem customizável.
  • Alterações na HomeView para poder ver o loading acontecendo, foi adicionado um AsyncAfter com deadline de .now + 3 segundos.
  • adicionado função para mostrar e esconder a LoadingView na HomeView.

Checklist:

  • [ x ] Não adiciona código duplicado
  • [ x ] Não contém código comentado
  • [ x ] Não contém código WIP
  • [ x ] Teste Unitário Implementado

Evidências:

iPhone SE iPhone 13 Pro Max
Simulator Screen Shot - iPhone SE (2nd generation) - 2022-02-22 at 00 43 25 Simulator Screen Shot - iPhone 13 Pro Max - 2022-02-22 at 00 39 47

MichaelDouglasCS
MichaelDouglasCS reviewed Feb 22, 2022
View reviewed changes
solutions/devsprint-michael-douglas-2/DeliveryApp/Screens/Components/LoadingView.swift Outdated Show resolved Hide resolved
solutions/devsprint-michael-douglas-2/DeliveryApp/Screens/Components/LoadingView.swift Outdated Show resolved Hide resolved
solutions/devsprint-michael-douglas-2/DeliveryApp/Screens/Components/LoadingView.swift Outdated Show resolved Hide resolved
solutions/devsprint-michael-douglas-2/DeliveryApp/Screens/Components/LoadingView.swift Outdated Show resolved Hide resolved
solutions/devsprint-michael-douglas-2/DeliveryApp/Screens/Home/HomeView.swift Outdated Show resolved Hide resolved
solutions/devsprint-michael-douglas-2/DeliveryApp/Screens/Home/HomeView.swift Show resolved Hide resolved
solutions/devsprint-michael-douglas-2/DeliveryApp/Screens/Home/HomeViewController.swift Outdated Show resolved Hide resolved
solutions/devsprint-michael-douglas-2/DeliveryApp/Screens/Home/HomeViewController.swift Outdated Show resolved Hide resolved
@MichaelDouglasCS
Copy link
Contributor

MichaelDouglasCS commented Feb 23, 2022 •
edited

Nice!!! Agora só faltam os Testes Unitários para conseguirmos mergear o seu PR 🚀 . Hoje a noite iremos falar sobre Testes.

@HyagoHenrique HyagoHenrique changed the title [ViewCode-MD] - [WIP] LoadingView component with custom message [ViewCode-MD] - LoadingView component with custom message Feb 23, 2022
MichaelDouglasCS
MichaelDouglasCS approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@MichaelDouglasCS MichaelDouglasCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelDouglasCS MichaelDouglasCS merged commit ad49406 into devpass-tech:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDouglasCS MichaelDouglasCS MichaelDouglasCS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HyagoHenrique @MichaelDouglasCS