Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ - Settings Module (Stage 1) #58

Closed
wants to merge 3 commits into from
Closed

✨ - Settings Module (Stage 1) #58

wants to merge 3 commits into from

Conversation

dbgarcia
Copy link

@dbgarcia dbgarcia commented Nov 9, 2022 •
edited

Description

Task: Implement Settings module's structure

Acceptance criteria:

  • Implement structure (folders and files) following VIP/Clean Code architecture
  • The module must work after the structure implementation. It should be possible to instantiate it and show it on screen
  • Implement only the base structure, not the API integration and presentation of the data coming from it
  • Implement unit tests

Checklist:

  • Doesn’t add duplicated code
  • Doesn’t contain commented code Não contém código comentado
  • Doesn't contain WIP code

Feature Preview:

iPhone SE iPhone 12 Max
print print

@dbgarcia
Settings Module - Stage 1
1ed79d6 
The currently implementation is basic structure, next stage will is layer calling network.
@dbgarcia dbgarcia changed the title Settings Module - Stage 1 🚧 - Settings Module (Stage 1) Nov 9, 2022
@dbgarcia
Copy link
Author

dbgarcia commented Nov 9, 2022 •
edited

Hey @bocato !

@dbgarcia dbgarcia marked this pull request as ready for review November 9, 2022 20:06
@dbgarcia dbgarcia changed the title 🚧 - Settings Module (Stage 1) ✨ - Settings Module (Stage 1) Nov 11, 2022
@rdgborges rdgborges closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbgarcia @rdgborges