Document SNI compatible mode on Python 2.x #21
Comments
|
Original comment by @jezdez Oh I forgot what SNI is, it helps hosters to not have to have one IP per SSL-enabled endpoint: http://en.wikipedia.org/wiki/Server_Name_Indication |
|
Original comment by @hpk42 maybe a good time to consider allowing a |
|
Original comment by @jezdez Sure, sounds like a plan! |
|
Original comment by @hpk42 unreleasedavoid depending on requests-2.0.1 which does not support SNI. → <> |
|
Original comment by @hpk42 So requests/pip on python3 support SNI without any extra dependencies? I am thinking of just adding the dependencies to "devpi-client" on Python2 so users don't have to worry. |
|
Original comment by @fschulze With environment markers we can easily add the dependency, we just need confirmation on which dependencies are needed. |
|
Original comment by @jhermann An easy way to achieve this is depending on requests[security] (only needed for <2.7.9 afaik). |
|
Original comment by @fschulze I consider this obsolete now. SNI is supported since 2.7.9. See https://www.python.org/downloads/release/python-279/ and https://www.python.org/dev/peps/pep-0466/ |
devpi-client uses the requests library which in turn uses the vendored urllib3 library.
Given Python 2.x's lack of SNI support urllib3 added support for it based on a few packages which when available add the feature even on 2.x. The actually packages to install are only documented in the file though: https://github.com/shazow/urllib3/blob/97f0c840052c696490be1e3cc77e00bc30f78b44/urllib3/contrib/pyopenssl.py#L5-L7
So I think it would be worthwhile to add this to a section of devpi somewhere:
The text was updated successfully, but these errors were encountered: