Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The action says "like" but implementation uses "votes" #37

Open
jimmynguyc opened this issue Sep 10, 2016 · 0 comments
Open

The action says "like" but implementation uses "votes" #37

jimmynguyc opened this issue Sep 10, 2016 · 0 comments

Comments

@jimmynguyc
Copy link
Collaborator

We should consider changing to "likes" instead of "votes" since they work abit differently in act_as_votable.

Likes are just likes. But Votes has up (positive) and down (negative) votes. Of course both can be undone, but it doesn't really mean the same thing. And the implementation should follow the design purpose of the gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants