Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature full Windows #87

Closed
devshgraphicsprogramming opened this issue Apr 15, 2021 · 5 comments
Closed

Feature full Windows #87

devshgraphicsprogramming opened this issue Apr 15, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@devshgraphicsprogramming
Copy link
Member

devshgraphicsprogramming commented Apr 15, 2021

Description

Allow for resizes, minimizes, maximizes and rotations (mobile).

Some platforms' implementations wont allow for certain things, so capabilities must be queryable at runtime and most operations should return a bool or an enum to notify of success (please no static capability sets via inheritance).

One example is a resize, which may not be achievable to the requested size, so the actual size after the operation (same as current if nothing done) needs to be returned)

Solution proposal

To be implemented separately in every derived window class for Win32, X11, Wayland, derivations of ForeignWindow (SDL2 which we shall use for Android)

Probably an window event callback needs to be able to be hooked up (at least to notify of an On-Resize).

Additional context

The window functions from the IrrlichtDevice need to die
https://github.com/Crisspl/Nabla/blob/vulkan/include/IrrlichtDevice.h#L191
https://github.com/Crisspl/Nabla/blob/vulkan/include/IrrlichtDevice.h#L114

@devshgraphicsprogramming
Copy link
Member Author

@Crisspl & @sadiuk status?

@Crisspl
Copy link
Collaborator

Crisspl commented Jul 15, 2021

Files (no file mapping yet) and window events (no rotations) have just been tested on Windows and works fine. Also IFile doesnt hold ISystem yet (@sadiuk most recent TODO is merge your smart refctd ptr changes and have it done).

@devshgraphicsprogramming
Copy link
Member Author

this issue is about UI Windows, not system

@devshgraphicsprogramming
Copy link
Member Author

@achalpandeyy I'll ask you for an example in the near future

@devshgraphicsprogramming
Copy link
Member Author

in progress by by @deprilula28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants