Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file validation should evaluate environment variables #13

Closed
babadofar opened this issue Oct 10, 2019 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@babadofar
Copy link

kafka-shell works fine using environment variables for bootstrap server and zookeeper, but barfs at schema_registry_url due to a validation error
To Reproduce
Use a config.yaml file like this

version: 1
enable:
  history: true
  save_on_exit: true
  auto_complete: true
  auto_suggest: true
  inline_help: true
  fuzzy_search: true
cluster: local
clusters:
  local:
    bootstrap_servers: $BOOTSTRAP_SERVER
    zookeeper_connect: $ZOO_KEEPER
    schema_registry_url: $SCHEMA_REGISTRY

Expected behavior
It should evalute the environment variables
Screenshots

[root@d89fde020d7f /]# kafka-shell
Invalid user configuration (clusters, local, schema_registry_url): '$SCHEMA_REGISTRY' does 
not match '^https?://(.*)$'
@babadofar babadofar added the bug Something isn't working label Oct 10, 2019
@devshawn
Copy link
Owner

Hey, thanks for the detailed bug report. This wasn't a use case I considered heavily -- but definitely a great idea. I'll take a look at this tonight and get a fix out.

@devshawn
Copy link
Owner

Hi there, schema_registry_url and ksql_server_url will now accept environment variables. I've released 0.1.2 to address this.

Please let me know if there are any other configuration settings that you'd like to work with environment variables. Thanks!! :)

@babadofar
Copy link
Author

🏆 awesome work! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants