Custom Prefix configuration #23
Conversation
dawsonfi
commented
Apr 7, 2017
dawsonfi
commented
- Extracted the prefix match to a function
- Added configuration to allow custom prefixes
src/yetibot/core/handler.clj
Outdated
| ([body prefix] | ||
| (re-find (re-pattern (str "^\\" prefix "(.+)")) body))) | ||
|
|
||
| (def ^:private config-prefix (:value (get-config sch/Str [:command :prefix]))) |
There was a problem hiding this comment.
Could bake the default in here in order to avoid multi-arity has-command-prefix? function, e.g.:
(def ^:private config-prefix
(or (:value (get-config sch/Str [:command :prefix])) "!"))There was a problem hiding this comment.
Loved the ideia of the default prefix logic in the config-prefix.
src/yetibot/core/handler.clj
Outdated
| @@ -68,7 +79,9 @@ | |||
| (when-let [parsed-cmds | |||
| (or | |||
| ; if it starts with a command prefix (!) it's a command | |||
| (when-let [[_ body] (re-find #"^\!(.+)" body)] | |||
| (when-let [[_ body] (if (nil? config-prefix) | |||
There was a problem hiding this comment.
Then here you don't have to check (nil? config-prefix). Simplifies to:
(when-let [[_ body] (has-command-prefix? body config-prefix)]There was a problem hiding this comment.
Great, with that the code is much cleaner now. Thanks for the suggestion.
src/yetibot/core/handler.clj
Outdated
| @@ -52,6 +54,15 @@ | |||
| ; ensure prefix is actually a command | |||
| (filter #(command? (-> % second second second))))) | |||
|
|
|||
| (defn has-command-prefix? | |||
| "Returns true if body has an command matching the prefix" | |||
There was a problem hiding this comment.
This docstring isn't quite right: this function will return the body of the command if it looks like a command, otherwise nil. The semantics match re-find. Because of this I'd probably rename the function (I typically only use ? suffix if the function actually returns a boolean). Maybe something like extract-command.
There was a problem hiding this comment.
Sorry, i haven't noticed that the regex returned the command. I have fixed it with your suggestions.
Thanks for the help.
|
Hi @devth, i've made the requested changes. If you have any further comment, please let me know. |
|
@dawsonfi thanks, looks good! 👍 |
