Fix For Issue #455 #646
Merged
Fix For Issue #455 #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allows for scraping multiple pages of memes Default set to 3 pages
Codecov Report
@@ Coverage Diff @@
## master #646 +/- ##
==========================================
- Coverage 41.6% 41.49% -0.12%
==========================================
Files 72 72
Lines 2026 2034 +8
Branches 79 79
==========================================
+ Hits 843 844 +1
- Misses 1104 1111 +7
Partials 79 79Continue to review full report at Codecov.
|
-Idea from: mmazi/rescu#54 (comment) Not sure if this is something that clj-http should be stripping out on their end? This might just be a hack, and there is a better way to go about this? Also, adding [cheshire] as a dependency might fix it as well, although when I tried that, it still gave the same error (cheshire is a dependency of clj-http when using the :as :json feature of clj-http/get see [here](https://github.com/dakrone/clj-http#optional-dependencies) )
Woops, forgot to put this in a new branch
|
Looks good! I'm going to wait to merge until I have a chance to run the code tomorrow. |
|
This is awesome. Thanks @jkieberk! |
devth
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allows for scraping any number of pages
Hard-coded at 3 right now, but can be changed in future if needed (is this necessary?)