Focus on function in call tree #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtatum
force-pushed
the
focus-function
branch
from
8788f03
to
d161a94
Compare
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 57% 58.29% +1.29%
==========================================
Files 131 131
Lines 7026 7076 +50
Branches 1529 1544 +15
==========================================
+ Hits 4005 4125 +120
+ Misses 2631 2573 -58
+ Partials 390 378 -12
Continue to review full report at Codecov.
|
mstange
reviewed
Sep 1, 2017
| @@ -197,6 +201,14 @@ class ProfileCallTreeContextMenu extends PureComponent { | |||
| <MenuItem onClick={this.handleClick} data={{ type: 'focus-subtree' }}> | |||
| Focus on subtree | |||
| </MenuItem> | |||
| {inverted | |||
There was a problem hiding this comment.
I think you could have this menu item visible in all modes. Xcode calls this "Focus on calls made by <function>", so it's clear in which direction you're going regardless of the current view mode.
gregtatum
force-pushed
the
focus-function
branch
from
d161a94
to
be979a0
Compare
gregtatum
added
the
data transform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I held off on attempting to do the inverted version of this, as I wasn't sure if it was needed or made sense. Plus it's a smaller PR which is always nicer.