Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save settings for each “toy” #3

Closed
BreeceW opened this issue Sep 30, 2021 · 4 comments · Fixed by #23
Closed

Save settings for each “toy” #3

BreeceW opened this issue Sep 30, 2021 · 4 comments · Fixed by #23
Assignees
Labels
enhancement Idea of improvement of existing feature.

Comments

@BreeceW
Copy link

BreeceW commented Sep 30, 2021

Is your feature request related to a problem? Please describe.
Some of the tools have some options on the top. I would like it if there were a way to save settings for each tool. For example, I would always want to set the JSON formatter to use 4 spaces, but the default is 2 and it is not saved when I restart the app.

Describe the solution you'd like
I am thinking there could be a Set defaults button below the configuration.

Describe alternatives you've considered
Alternatively, you could just save the configuration automatically, but this could be annoying if you usually use one setting but need another just once.

Additional context
Json Formatter with Set default button located on the top right corner of the configuration
Low quality mockup

@veler
Copy link
Collaborator

veler commented Sep 30, 2021

Hello,

Thank you very much for this! It's a very fair point. I like both, the Set Default and the possibility to automatically save the selected options. I'd need to think more about it, but definitely like the suggestion.

Thank you so much. @btiteux , what do you think about?

@veler veler added the enhancement Idea of improvement of existing feature. label Sep 30, 2021
@btiteux
Copy link
Collaborator

btiteux commented Sep 30, 2021

Hello,

The set button is definitely a good idea. Thank you for the request. We would need to find the best place for it.

For the the save auto, it could be annoying if for a specific case you need to adjust the settings of a toy. Maybe we can look to add a section or button in the app settings to save all the "toys" settings at the same time.

@veler
Copy link
Collaborator

veler commented Sep 30, 2021

I'm wondering: how often does a user need to change the settings, and how often does a user would like to keep them the way they are after restarting the app?
While I don't have data to answer these questions, I'm thinking that in a first implementation, just persisting the settings the way they are when closing the app is probably enough.
Thoughts?

@veler veler self-assigned this Oct 10, 2021
@veler veler mentioned this issue Oct 10, 2021
11 tasks
@veler veler linked a pull request Oct 10, 2021 that will close this issue
11 tasks
@veler
Copy link
Collaborator

veler commented Oct 10, 2021

Thanks again @BreeceW for your suggestion :) I've been with the alternative solution for now. It will be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea of improvement of existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants