Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Edit failing to update #1850

Closed
2 tasks done
pawan-59 opened this issue Jun 8, 2022 · 0 comments · Fixed by #1855
Closed
2 tasks done

Bulk Edit failing to update #1850

pawan-59 opened this issue Jun 8, 2022 · 0 comments · Fixed by #1855
Assignees
Labels
bug Something isn't working

Comments

@pawan-59
Copy link
Contributor

pawan-59 commented Jun 8, 2022

If you are trying to resolve an environment-specific issue or have a one-off question about the edge case that does not require a feature then please consider asking a question in Devtron Discord channel.

Checklist:

  • I've searched in the docs and FAQ for my answer
  • I've included steps to reproduce the bug.

Describe the bug

I tried to update the application config using the bulk-edit option but It is failing.
Here is the script that I'm trying.
apiVersion: batch/v1beta1
kind: Application
spec:
includes:
names:
- "demo-8-jun"
global: true
deploymentTemplate:
spec:
patchJson: '[{ "op": "add", "path": "/MaxSurge", "value": 2 },{"op": "replace","path":"/GracePeriod","value": "300"}]'

To Reproduce

[ordered list the process to finding and recreating the issue, example below]

  1. Go to the bulk-edit option.
  2. Paste the above yaml with any of your application names.
  3. Try to run the script

Expected behavior

It should update the configuration or show the error message in updating the config on the UI itself.

Logs

orchestrator-cd-devtroncd-68b6bb5c98-zr74t: 2022/06/08 17:49:22 http: panic serving 100.114.15.213:45914: runtime error: invalid memory address or nil pointer dereference
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: goroutine 142445 [running]:
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: net/http.(*conn).serve.func1(0xc001040280)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /usr/local/go/src/net/http/server.go:1804 +0x153
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: panic(0x247f760, 0x3cb45f0)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /usr/local/go/src/runtime/panic.go:971 +0x499
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: github.com/devtron-labs/devtron/pkg/pipeline.BulkUpdateServiceImpl.GetBulkAppName(0x2c93570, 0xc000568680, 0x2c871a0, 0xc000b28598, 0xc000010260, 0x2c73678, 0xc0009b46e8, 0x2c829d8, 0xc0001d8380, 0xc000010260, ...)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /go/src/github.com/devtron-labs/devtron/pkg/pipeline/BulkUpdateService.go:216 +0x2681
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: github.com/devtron-labs/devtron/api/restHandler.BulkUpdateRestHandlerImpl.BulkUpdate(0x2c98ec8, 0xc00001d8c0, 0x2c943a0, 0xc0006671c0, 0x2c898b0, 0xc0012451e0, 0xc000010260, 0x2c73718, 0xc0006f5040, 0x2c956e8, ...)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /go/src/github.com/devtron-labs/devtron/api/restHandler/BulkUpdateRestHandler.go:210 +0x3ca
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: net/http.HandlerFunc.ServeHTTP(0xc0009f87c8, 0x7fe7fe7b9d00, 0xc0019a88c0, 0xc002c64700)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /usr/local/go/src/net/http/server.go:2049 +0x44
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: github.com/devtron-labs/devtron/internal/middleware.PrometheusMiddleware.func1(0x2c52ee8, 0xc0005bf5e0, 0xc002c64700)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /go/src/github.com/devtron-labs/devtron/internal/middleware/instrument.go:72 +0x22f
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: net/http.HandlerFunc.ServeHTTP(0xc00102c780, 0x2c52ee8, 0xc0005bf5e0, 0xc002c64700)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /usr/local/go/src/net/http/server.go:2049 +0x44
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: github.com/gorilla/mux.(*Router).ServeHTTP(0xc0007de000, 0x2c52ee8, 0xc0005bf5e0, 0xc002a1e600)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /go/src/github.com/devtron-labs/devtron/vendor/github.com/gorilla/mux/mux.go:210 +0xd3
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: github.com/devtron-labs/authenticator/middleware.Authorizer.func1.1(0x2c52ee8, 0xc0005bf5e0, 0xc002a1e600)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /go/src/github.com/devtron-labs/devtron/vendor/github.com/devtron-labs/authenticator/middleware/AuthMiddleware.go:62 +0xfa
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: net/http.HandlerFunc.ServeHTTP(0xc0018fe630, 0x2c52ee8, 0xc0005bf5e0, 0xc002a1e600)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /usr/local/go/src/net/http/server.go:2049 +0x44
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: net/http.serverHandler.ServeHTTP(0xc000464460, 0x2c52ee8, 0xc0005bf5e0, 0xc002a1e600)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /usr/local/go/src/net/http/server.go:2867 +0xa3
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: net/http.(*conn).serve(0xc001040280, 0x2c5c3c0, 0xc001b5a3c0)
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /usr/local/go/src/net/http/server.go:1932 +0x8cd
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: created by net/http.(*Server).Serve
orchestrator-cd-devtroncd-68b6bb5c98-zr74t:     /usr/local/go/src/net/http/server.go:2993 +0x39b
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: /service-worker.js
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: /service-worker.js
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: /precache-manifest.837b29d0e0919bce7d73d2e5c2c8a349.js
orchestrator-cd-devtroncd-68b6bb5c98-zr74t: /service-worker.js
@pawan-59 pawan-59 added the bug Something isn't working label Jun 8, 2022
@kartik-579 kartik-579 linked a pull request Jun 9, 2022 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants