Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: CI-node label selector not working using app label #4092

Closed
2 tasks done
pawan-59 opened this issue Oct 13, 2023 · 0 comments · Fixed by #4084
Closed
2 tasks done

Bug: CI-node label selector not working using app label #4092

pawan-59 opened this issue Oct 13, 2023 · 0 comments · Fixed by #4084
Assignees
Labels
bug Something isn't working pager-duty Bugs / Issues found while on pager duty

Comments

@pawan-59
Copy link
Contributor

pawan-59 commented Oct 13, 2023

📜 Description

Previously we were using app labels to define node selectors for CI on the application like selecting ARM-based machine or AMD-based machine to build the code but now this node selector is not working.

👟 Reproduction steps

  1. Create an application and configure the build pipeline in the application
  2. Now use the below label on app labels. Go to the overview page and add the label.
    Key: devtron.ai/node-selector
    Value: {"purpose": "arm-ci"}
  3. Trigger the CI and check the manifest of the CI it won't use the given label.

👍 Expected behavior

It should use the node Selector as mentioned in the labels.

👎 Actual Behavior

It's not using the labels mentioned in the app labels, but using the default selector configured in orchestrator configmap.

☸ Kubernetes version

1.26

Cloud provider

AWS

🌍 Browser

Chrome

🧱 Your Environment

No response

✅ Proposed Solution

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

AB#6192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pager-duty Bugs / Issues found while on pager duty
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants