You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am unable to delete chart-repos on safari. Chrome and Firefox do not show this issue.
Whenever I try to delete a chart repo on Safari I get an EOF (Bad response).
👟 Reproduction steps
Open safari
Navigate to Chart Repositories under Global Configurations
Try and delete any of the chart repos
Pressing the delete button should give an EOF error
👍 Expected behavior
The repository should be deleted with the following response
Minikube v1.32.0 on Darwin 14.2.1 (arm64)
Kubernetes v1.28.3 on Docker 24.0.7
Cloud provider
NaN
🌍 Browser
Safari
🧱 Your Environment
I have installed Devtron on minikube by following the instructions provided on the documentation pages
✅ Proposed Solution
The dashboard will send the first request at DELETE /orchestrator/chart-repo. The correct address is /orchestrator/chart-repo/ (with a trailing slash) [Ideally a REST API should not have a trailing slash?]. Since the frontend sends the request without the trailing slash, the server sends a Redirect response of 301: Moved Permanently. This causes the frontend to send another request but this time the content-body has a length of 0. That is the request is being sent without the body. If the server had sent a response with code of 308 instead of 301 the body would have stayed intact, and thus the request would have gone through successfully.
Thus this situation can be handled through the following methods -
Through Backend: Remove the trailing slash from the endpoint or send a redirect response with error code of 308 instead of 301.
Through Frontend: Add a trailing slash to the request being sent. Can be done by adding it to the line number 30 of dashboard/src/components/chartRepo/chartRepo.service.tsx
👀 Have you spent some time to check if this issue has been raised before?
📜 Description
I am unable to delete chart-repos on safari. Chrome and Firefox do not show this issue.
Whenever I try to delete a chart repo on Safari I get an EOF (Bad response).
👟 Reproduction steps
👍 Expected behavior
The repository should be deleted with the following response
👎 Actual Behavior
The repository is not deleted. Instead we get a BAD REQUEST response message.
☸ Kubernetes version
Minikube v1.32.0 on Darwin 14.2.1 (arm64)
Kubernetes v1.28.3 on Docker 24.0.7
Cloud provider
NaN
🌍 Browser
Safari
🧱 Your Environment
I have installed Devtron on minikube by following the instructions provided on the documentation pages
✅ Proposed Solution
The dashboard will send the first request at DELETE /orchestrator/chart-repo. The correct address is /orchestrator/chart-repo/ (with a trailing slash) [Ideally a REST API should not have a trailing slash?]. Since the frontend sends the request without the trailing slash, the server sends a Redirect response of 301: Moved Permanently. This causes the frontend to send another request but this time the content-body has a length of 0. That is the request is being sent without the body. If the server had sent a response with code of 308 instead of 301 the body would have stayed intact, and thus the request would have gone through successfully.
Thus this situation can be handled through the following methods -
👀 Have you spent some time to check if this issue has been raised before?
🏢 Have you read the Code of Conduct?
AB#8207
The text was updated successfully, but these errors were encountered: