New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version (1.5.0.19) #95
Comments
google.com.br was not working so i add this: |
When I try The script gets it from the tag Looking at the source code of the results' page, what do you see as the "lang" attribute of the html tag? I don't think that adding |
Do you see any error message in the console when using the unmodified script? What browser are you using ? |
I tested it on firefox 69.0.1 (32-bit) with the code unmodified and it worked. Do you think that if I clear the cache it could work? |
I pretty sure clearing won't solve the issue. Which extension are you using to run the script? Tampermonkey? How have you installed the script? |
Violentmonkey
I installed from the url Google Search "View Image" Button
raw file from your fork it's weird because it works on firefox but it doesn't work on chromium |
I've tried wth Violentmonkey in a test profile, and I have no problem with the script. Are there different values for the counter displayed on VM icon with and without your modification? |
I can suggest some more tests:
|
I created a new profile and it worked! |
OK,
|
Fix for the color of "search by image" link. (darkgray on black background isn't really visible ;) ) Since this is a small fix, I'll update my fork immediately.
|
Thanks man! It is sad, that "updates" not always bring some good stuff, but sometimes ruin old good stuff, but it is great there are people that can bring back what is useful) |
I don't know why they are always messing up with their layout and features. We've a saying in french, something like "it's changing for changing". (no other purpose than the change itself) |
Salut Marc @Procyon-b This is not working for me with that new "Side Panel" layout on Google. I'm using Violent Monkey in Firefox 77. Could it be the issue where CSP is preventing script injection? VM says the script is active, but no Show button :-( Best Regards, |
Salut @B00ze64 |
Salut @Procyon-b, alors suite a ton commentaire, je teste avec un nouveau profil, et ça marche! Ah ben maudit! Alors je re-teste avec mes 2 autres profils et ça marche aussi! Je te dis, hier ça fonctionnait pas, estie! lol. C'est plein de situations comme ça avec Firefox, des fois y'a des trucs qui fonctionnent pas pour aucune raison apparente. Merci de continuer à mettre à jour ton script, c'est pas facile d'en trouver un à jour. Y'a 50 FORKs du script ici, et pas un (sauf le tiens) est gardé à jour. PS: Tu pourrais activer les "Issues" sur ton Fork, tant qu'à utiliser le issue tracker de quelqu'un d'autre. PPS: Le "Side Panel" c'est le "nouveau" layout de Google où l'image apparaît à la droite - pour moi c'est nouveau parce que je fais des recherches d'images seulement quelques fois par année. Allez, merci encore! A+ EDIT: For all English Speakers -> No worries, script works, my bad. |
J'ai aussi déjà eu (dans chrome) des problèmes (avec tampermonkey par ex.) où redémarrer le navigateur était indispensable pour rétablir le comportement normal. A noter que, par défaut, chrome a une option qui lui permet de continuer à tourner même après l'avoir fermé (une option dont l'intitulé est du genre "Continue running background apps when Google Chrome is closed"). Et donc, dans ce cas, fermer et redémarrer chrome ne fait pas vraiment ce à quoi on s'attend, puisqu'il n'est pas vraiment arrêté.
Je me suis dévoué quand j'ai vu que @devunt n'avait pas le temps de s'occuper des mises à jour. :) |
Salut! C'est exactement ce que je pense, le "Multi-Process" (exécution non-synchronisée) cause des problèmes parce que dans Firefox il y a des endroits où plusieurs extensions peuvent modifier une requête/page (comme par exemple les Headers) et la première qui y touche gagne sur les autres. Ils ont corrigé ça à certains endroits mais pas partout. Il y a d'autres problèmes aussi; Firefox est en retard sur Chrome, et c'est long de faire corriger des bugs; ils travaillent surtout à rattraper Chrome hehe. Pour ton fork, c'est correct si tu préfères utiliser le repo d'origine, tant qu'à être obligé de changer de nom etc. L'extension n'est même plus sur le site de Mozilla, lol. Il y en a une autre (https://addons.mozilla.org/en-US/firefox/addon/view-image/) mais elle souffre du même problème, c-a-d que l'auteur ne la garde pas tout à fait à jour. Elle ne fonctionne qu'à demie. Enouka, merci d'être ici, c'est pratique ce bouton View Image! :-) |
Fixes to ensure the original full-size image is used.
Latest version is below |
Another variation of the layout has appeared.
Latest version is below |
name of a style has changed
|
Long time no see... Noticed today that our button wasn't there. Just a classname changed.
Latest version is below |
@Procyon-b i think it broke again. please save us. 🙏 also you might as well set the script homepage to your fork. and the update url. you're the man. |
@ftc2 you're lucky. I was able to reproduce only with my current cookies. Whenever I tried to trigger this layout variation with other cookies/TLDs the button was added. I keep the original homepage because issues are here, but I've added the updateurl of my fork. Those who have added the script from that url are already updated automatically. The fix is as usual just a classname change.
Latest version is below |
awesome, thanks!
|
It isn't needed because the script is already located at the right place. Every userscripts managers I've tested (3 or 4) uses either the updateURL or the script installation location to check for updates. Am I missing something? |
i had no idea! i thought |
It's useful when you host the code on different servers and want to direct every update to one copy/server only. |
Two new designs for the buttons are currently tested.
|
@Procyon-b script seems broken again(checked in FF and Opera), can you update it..? |
Can you also make this compatible for mobile version too? |
This is the lastest version. It contains a small fix to display the "search by image link" on the side-panel.
I post this in a new thread to make it easier to locate for newcomers.
The code in my fork has been updated. Those still using this as a source for the userscript in tampermonkey will be updated automatically.
Here is the method to use it that way:
Those who want to have the script automatically updated from my fork can use the "Raw" button on the script page. Tampermonkey detects that it is a userscript, and proposes to install it. And it will automatically be updated when a newer version appears.
The text was updated successfully, but these errors were encountered: