Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add contributors section to readme file #77

Closed
devvsakib opened this issue Jan 23, 2023 · 21 comments
Closed

add contributors section to readme file #77

devvsakib opened this issue Jan 23, 2023 · 21 comments
Assignees
@MohamedAlDeep
Labels
documentation Improvements or additions to documentation EddieHub:good-first-issue

Comments

@devvsakib
Copy link
Owner

add contributors section to readme file
image
@MohamedAlDeep
Copy link
Contributor

You mean the names in a table?

@devvsakib
Copy link
Owner Author

@MohamedAlDeep check this repository
https://github.com/devvsakib/power-the-web

@MohamedAlDeep
Copy link
Contributor

MohamedAlDeep commented Jan 23, 2023 •
edited
Loading

@devvsakib

so the link of contributors https://github.com/devvsakib/github-error-solve/graphs/contributors
+
the image of them ?

@MohamedAlDeep
Copy link
Contributor

Also do you mean to have contributors json file ? and those things (the above is included)

@MohamedAlDeep
Copy link
Contributor

MohamedAlDeep commented Jan 23, 2023 •
edited
Loading

With the contributors page
in the app

@devvsakib
Copy link
Owner Author

@MohamedAlDeep no need any JSON file, but if you want to do this, it will be plus

@MohamedAlDeep
Copy link
Contributor

@devvsakib
I can do it but for now i need the image of contributors or what do you think
image

@MohamedAlDeep
Copy link
Contributor

@devvsakib can you assign me

@devvsakib
Copy link
Owner Author

lets do it @MohamedAlDeep

@devvsakib
Copy link
Owner Author

use this link for images https://contrib.rocks/image?repo=devvsakib/github-error-solve

@MohamedAlDeep
Copy link
Contributor

@devvsakib Do you want to change text ?
image

@MohamedAlDeep
Copy link
Contributor

@devvsakib i think all done

@MohamedAlDeep
Copy link
Contributor

image

@MohamedAlDeep
Copy link
Contributor

image

@MohamedAlDeep
Copy link
Contributor

responsive
image
also i dont know if this css is good for this but i just took the css of the others

@MohamedAlDeep
Copy link
Contributor

Uploading image.png…
hover

@MohamedAlDeep
Copy link
Contributor

image
hover

@MohamedAlDeep
Copy link
Contributor

MohamedAlDeep commented Jan 23, 2023 •
edited
Loading

@devvsakib so i added json data

@MohamedAlDeep
Copy link
Contributor

added header to contributions
image

@devvsakib
Copy link
Owner Author

perfect, create an issue on creating contibutors page, I'll assign you @MohamedAlDeep

@devvsakib
Copy link
Owner Author

I raised an issue, you can comment there I'll assign you.
But make sure you make 2 PR. one for this issue and another for contrubutors page issue

@MohamedAlDeep MohamedAlDeep mentioned this issue Jan 23, 2023
Closed
@devvsakib devvsakib added EddieHub:good-first-issue documentation Improvements or additions to documentation labels Jan 23, 2023
@MohamedAlDeep MohamedAlDeep mentioned this issue Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohamedAlDeep MohamedAlDeep

Labels
documentation Improvements or additions to documentation EddieHub:good-first-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devvsakib @MohamedAlDeep