Thoughts on using private structs in the file that declares the endpoints?

[AndrewSB]

This is awesome @devxoul 😄

I ran across Moya/Moya#447, and it made me wonder if it made any sense to use something like it in MoyaSugar, or if it makes more sense as is?

I'm really not sure, but the article included in the issue piqued my interest

[devxoul]

My poor English 😥 Could you please ask me again in plain English? I couldn't understand:

...wonder if it made any sense to use something like it in MoyaSugar, or if it makes more sense as is?

[AndrewSB]

Don't blame yourself! Looking back, I was really unclear 🙄

I was wondering if you saw any potential upside to changing parts of the implementation of MoyaSugar to use the pattern discussed in Moya/Moya#447, or if the potential upside is negligible

[devxoul]

@AndrewSB, oh I see. I think It would be something like:

extension GitHubAPI : SugarTargetType {

  var request: SugarRequest {
    switch self {
    case .userRepos(let owner):
      return SugarRequest(
        route: .get("/users/\(owner)/repos"),
        httpHeaderFields: [
          "Accept": "application/json"
        ]
      )

    case .createIssue(let owner, let repo, let title, let body):
      return SugarRequest(
        route: .post("/repos/\(owner)/\(repo)/issues"),
        parameters: [
          "title": title,
          "body": body,
        ],
        parameterEncoding: JSONEncoding(),
        httpHeaderFields: [
          "Accept": "application/json"
        ]
      )

    case .editIssue(let owner, let repo, let number, let title, let body):
      return SugarRequest(
        route: .patch("/repos/\(owner)/\(repo)/issues/\(number)"),
        parameters: [
          "title": title,
          "body": body,
        ],
        httpHeaderFields: [
          "Accept": "application/json"
        ]
      )
    }
  }

}

But I'm not sure this is better than before.

[AndrewSB]

Yeah, you're right @devxoul - I like the current layout better than this one with SugarRequest structs, thank you for taking the time to give this some thought!