Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AsyncDNS arduino-esp32-compatible #3

Open
drws opened this issue Mar 3, 2021 · 8 comments
Open

Make AsyncDNS arduino-esp32-compatible #3

drws opened this issue Mar 3, 2021 · 8 comments

Comments

@drws
Copy link

drws commented Mar 3, 2021

Currently ESPAsyncDNSServer includes ESPAsyncUDP with #include <ESPAsyncUDP.h>. However, AsyncUDP is natively included in arduino-esp32 since 2018 and can be included in Arduino ESP32 projects with #include <AsyncUDP.h> only. Currently, this library is not compatible with arduino-esp32 out-of-the-box or am I missing anything?

@devyte
Copy link
Owner

devyte commented Mar 21, 2021

I don't use esp32, and I don't plan to in the near future.
However, if you make a PR I'll take a look.

@guestisp
Copy link
Contributor

@drws use this on ESP32: https://github.com/guestisp/ESP32AsyncDNSServer

@devyte
Copy link
Owner

devyte commented May 21, 2022

Proposed PR has been merged.

@guestisp
Copy link
Contributor

thank you

@bradjshannon
Copy link

This change is not reflected in the version PlatformIO installs automatically. This caused errors about missing dependencies for esp8266 when compiling my esp32 project.

I do not know how the PlatformIO Registry is updated, or who is responsible. Maybe @devyte can push the update somehow?

@devyte
Copy link
Owner

devyte commented Dec 15, 2022

I don't know about pushing anything, I don't use PIO myself, so I have no idea how this lib is integrated there. But I can make changes within this repo if that helps anyone. So if anyone knows what needs to be done here, or better yet: proposes the needed changes in a PR, I can look into it.

@bradjshannon
Copy link

I bet if you just change the version number, it'll trigger PIO to get the latest?

@maxgerhardt
Copy link

PR open for this in #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants