Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude generated files from code coverage report #36

Closed
bartebor opened this issue Jul 5, 2022 · 6 comments
Closed

Exclude generated files from code coverage report #36

bartebor opened this issue Jul 5, 2022 · 6 comments

Comments

@bartebor
Copy link

bartebor commented Jul 5, 2022

Hello!
Generated code is currently included in code coverage reports which may be undesirable. It would be great to annotate generated classes with some custom @Generated annotation. Jacoco excludes such annotated files automatically. This feature could be configurable to suit different needs.

@deweyjose
Copy link
Owner

Hi @bartebor, thanks for the suggestion. I'll take a look over the coming days, it might be something the Netflix folks need to add to the core codegen library.

@bartebor
Copy link
Author

bartebor commented Jul 8, 2022

You are right; I filed issue in dgs-codegen project: Netflix/dgs-codegen#420

@deweyjose
Copy link
Owner

@bartebor thanks! As soon as they add support we'll integrate with the new version.

@yonatang
Copy link

hi @deweyjose , Netflix just merged my PR Netflix/dgs-codegen#424 to support that feature. I'd appreciate if you can add that to the maven plugin. Or, if you'd prefer, I can submit a PR for that as well?

@anidzgor
Copy link

Hello @deweyjose, 6 days ago Netflix release version v5.2.5, it would be great if it will be updated in your project :)
[v5.2.5]

@bartebor
Copy link
Author

Hi @deweyjose, dgs folks followed up on the issue and added custom @Generated annotation in https://github.com/Netflix/dgs-codegen/releases/tag/v5.2.6 to make JaCoCo happy. Could you update your project accordingly? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants