Upgraded dgscodegen to 5.0.3 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my previous comment I hadn't checked if this worked. I've now used it in a project and can confirm that it's working. Another day, another dollar :) |
|
Hi @karhig! Thank you for pushing this forward. I'll release this tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the latest version of dgs serializes queries incorrectly with the latest version of the maven codegen plugin. Namely, it doesn't use the graphql type name when generating the query fragment and instead uses the classname. This is because no
schemaTypeis provided in older versions of the generated code.Updating to the latest version of the code gen library fixes this when using the gradle plugin, so this is what I've tried to do here for the maven plugin.
This is my first time making a change to a maven plugin, so I hope it works. I'm not sure the best way of testing it. The best that can be said of this is that it compiles :)