Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop using slim version of gomplate #2053

Merged
merged 1 commit into from
Mar 20, 2021
Merged

Conversation

sagikazarmark
Copy link
Member

Overview

Stop using the slim version of gomplate

What this PR does / why we need it

Looks like the slim version of gomplate doesn't work well on arm (see hairyhenderson/gomplate#1085)

Fixes #2052

Special notes for your reviewer

Does this PR introduce a user-facing change?

Fix arm images by using the non-slim version of gomplate

See hairyhenderson/gomplate#1085

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible.

@sagikazarmark sagikazarmark merged commit a1adf86 into master Mar 20, 2021
@sagikazarmark sagikazarmark deleted the fix-gomplate-slim branch March 20, 2021 12:59
xtremerui pushed a commit to concourse/dex that referenced this pull request Mar 20, 2021
The official docker release for this release can be pulled from

```
ghcr.io/dexidp/dex:v2.28.1
```
**Bugfixes:**

- Fix gomplate on ARM (dexidp#2053, @sagikazarmark)
xtremerui pushed a commit to concourse/dex that referenced this pull request Apr 1, 2021
The official docker release for this release can be pulled from

```
ghcr.io/dexidp/dex:v2.28.1
```
**Bugfixes:**

- Fix gomplate on ARM (dexidp#2053, @sagikazarmark)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exec format error starting with v2.28 on arm64
2 participants