Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MySQL connection to use the provided port #2100

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Conversation

sagikazarmark
Copy link
Member

@sagikazarmark sagikazarmark commented Apr 26, 2021

Overview

The MySQL storage connector now uses the port field to allow connecting to MySQL instances running on a non-standard port.

What this PR does / why we need it

Fixes #2098

Special notes for your reviewer

Does this PR introduce a user-facing change?

Fix MySQL connection to use the provided port

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark changed the title ci: run mysql tests on non-standard port Fix MySQL connection to use the provided port Apr 26, 2021
@sagikazarmark sagikazarmark marked this pull request as ready for review April 26, 2021 09:29
@sagikazarmark sagikazarmark added this to the v2.29.0 milestone Apr 26, 2021
Copy link
Member

@nabokihms nabokihms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns about this PR. Just left a little comment.

storage/sql/config.go Outdated Show resolved Hide resolved
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot specify MySQL port
3 participants