Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ent-based postgres storage #2121

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Conversation

nabokihms
Copy link
Member

@nabokihms nabokihms commented May 14, 2021

Signed-off-by: m.nabokikh maksim.nabokikh@flant.com

Overview

  • Add constructor for Postgres storage
  • Tests for Postgres storage bootstrapping
  • Connect conformance tests

What this PR does / why we need it

Related #1864

Special notes for your reviewer

Composing DSN method and storage structure are mostly copypasted from the "raw SQL" storage. I think they are good enough to continue using them.

Does this PR introduce a user-facing change?

Add an experimental ent-based postgres storage.

Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms marked this pull request as draft May 14, 2021 19:32
@nabokihms nabokihms force-pushed the ent-postgres branch 3 times, most recently from f31698a to d87c9e6 Compare May 15, 2021 04:58
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms marked this pull request as ready for review May 15, 2021 05:29
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me. One question regarding passwords.

Is this something we want to include in 2.29 or delay it to 2.30?

Once etcd 3.5 is tagged, I want to release a new Dex version.

storage/ent/postgres.go Show resolved Hide resolved
@nabokihms
Copy link
Member Author

nabokihms commented May 17, 2021

We can leave it to 2.30 for sure.

@sagikazarmark sagikazarmark added this to the v2.30.0 milestone May 17, 2021
@nabokihms nabokihms merged commit 2211c51 into dexidp:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants