url is not always unique in _syncNodes

[martindiphoorn]

In some race conditions it is possible that there will be created an seconde entry in the _syncNodes. This happend to me when i was firing an disconnect and a connect right after each other.

Example:
On the login page i tell that sync should be disconnected. However when running from an app it should take the saved credentials and perform an login.

db.syncable.disconnect(url);

// some more code

if (isCordovaApp) {
   // do login
  db.syncable.connect(provider,url);
}

This way i have seen more then one entry for the same url in the _syncNodes objectStore. I have fixed this in my code by changing the order and using the promises returned.

My biggest problem is that after running the resync it sometimes returns all the current object store contents as type 1 or type 3 to the backend in the next sync. When looking closely at it, i noticed that there where 2 sync connections instead off 1.

[martindiphoorn]

I just found out that when i do an resync with ngDexie then there will also be 2 sync connections with the same name. Im going to fix this in ngDexie, by keeping a resync state, but maybe with this information you can find out better what is going wrong?

[nponiros]

@dfahlander does #412 with the unique url index fix this issue? If yes maybe we can close it.

[dfahlander]

Yes. Thanks. And merry Christmas :)

[nponiros]

Thanks. Same to you