Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish sign implementation #165

Closed
Sandertv opened this issue Jun 17, 2021 · 2 comments
Closed

Finish sign implementation #165

Sandertv opened this issue Jun 17, 2021 · 2 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@Sandertv
Copy link
Member

The sign implementation at feature/signs requires some minor changes to the way the rotation + wall/standing is structured. With some other small changes this should be ready to be merged into master.

@Sandertv Sandertv added the feature New feature or request label Jun 17, 2021
@Sandertv Sandertv added this to the v0.1.0 milestone Jun 17, 2021
@Sandertv Sandertv self-assigned this Jun 17, 2021
@Sandertv Sandertv assigned Sandertv and unassigned Sandertv Jun 28, 2021
@Sandertv
Copy link
Member Author

Going to postpone this to the start of v0.2.0. I don't have enough time to finish this in v0.1.0 and definitely not enough time to make sure it all works properly by the end of the month. v0.2.0 is a safer time to release.

@Sandertv Sandertv modified the milestones: v0.1.0, v0.2.0 Jun 29, 2021
@Sandertv
Copy link
Member Author

Sandertv commented Jul 9, 2021

Signs are quite far in now. The feature/signs branch has most of the implementation ready. There are a couple of things left to do:

  • Verify that only the owner can edit a sign.
  • Look up what colour codes (RGBA) correspond to which dye colours.
  • Figure out exactly what glow ink does to the text. (Seems like it just turns up the A channel of the RGBA to maximum?)
  • Maybe have some sort of event for sign editing, including dyeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant