Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cmd.SubCommand to a type that isn't an interface. #531

Closed
Sandertv opened this issue Jun 18, 2022 · 2 comments
Closed

Change cmd.SubCommand to a type that isn't an interface. #531

Sandertv opened this issue Jun 18, 2022 · 2 comments
Labels
improvement Improvement of an existing part of the codebase
Milestone
v0.8.0

Comments

@Sandertv
Copy link
Member

Instead of requiring implementation of this interface, we could simply make cmd.SubCommand a type that isn't an interface and allow using that as a parameter type directly. We could then use the field name and cmd:"" struct tag to let users specify the name of the subcommand. This means we wouldn't have to keep implementing new types for every subcommand.
@Sandertv Sandertv added the improvement Improvement of an existing part of the codebase label Jun 18, 2022
@Sandertv Sandertv added this to the v0.8.0 milestone Jun 18, 2022
@T14Raptor
Copy link
Member

adc6278 resolves this right?

@Sandertv
Copy link
Member Author

Yep, thanks for reminding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement of an existing part of the codebase
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
2 participants
@Sandertv @T14Raptor