HandleApplyEffect

[HashimTheArab]

This would allow users to easily modify an effect without creating a new custom one for little changes

Something like HandleApplyEffect(effect *effect.Effect) or HandleApplyEffect(effect effect.Effect, level *int, particlesHidden *bool, duration *time.Duration)

[Sandertv]

I have some reservations over this. Is this really a change that is necessary? Could you give an example where this can do something you wouldn't already be able to do differently?

[HashimTheArab]

For vasar kitpvp there's a perk that boosts the players speed level by 1 (only when they have a speed effect on)

What we could do is have a custom speed effect that implements that logic but even then the only thing we can modify is the level that's used in SetSpeed, we can't modify the actual level of the effect

Also it's a lot less convenient having to keep track of the custom effect making sure we only ever use that and not the dragonfly speed effect

[Sandertv]

Why isn't it possible to just create a new effect instance?

[HashimTheArab]

That would have to be in every place we apply a speed effect, we could have a user.ApplySpeed function and always use that instead of player.AddEffect to apply speed but that feels wrong and might cause import cycles

[Sandertv]

As discussed in the Discord, we chose not to add this because a function as proposed (user.ApplySpeed) would solve this. Adding a handler for this method opens a can of worms where it is no longer clear if all methods need a handler or not.