Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the design of block drops #590

Open
JustTalDevelops opened this issue Jul 24, 2022 · 1 comment
Open

Refactor the design of block drops #590

JustTalDevelops opened this issue Jul 24, 2022 · 1 comment
Labels
bug Something isn't working improvement Improvement of an existing part of the codebase
Milestone

Comments

@JustTalDevelops
Copy link
Member

JustTalDevelops commented Jul 24, 2022

Container blocks don't drop their items when you break them in creative because they get included within BreakInfo's drops, which is only utilized when the player is in survival.

Issues also exist with certain blocks, such as vines, that need to check for silk touch on a specific tool.

@JustTalDevelops JustTalDevelops added the bug Something isn't working label Jul 24, 2022
@JustTalDevelops JustTalDevelops added this to the v0.8.0 milestone Jul 24, 2022
@JustTalDevelops
Copy link
Member Author

JustTalDevelops commented Jul 24, 2022

The issue here is the fact that there is no boundary between "definite drops" and "survival drops", both are grouped into the same drops portion of BreakInfo.

@JustTalDevelops JustTalDevelops changed the title Container blocks don't drop their items when you break them in creative Refactor the design of block drops Jul 24, 2022
@JustTalDevelops JustTalDevelops added the improvement Improvement of an existing part of the codebase label Jul 24, 2022
@DaPigGuy DaPigGuy modified the milestones: v0.8.0, v0.9.0 Aug 1, 2022
@DaPigGuy DaPigGuy modified the milestones: v0.9.0, v0.10.0 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improvement of an existing part of the codebase
Projects
None yet
Development

No branches or pull requests

2 participants