Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splash Bottles don't extinguish flames on a player. #610

Open
abimek opened this issue Jul 28, 2022 · 0 comments
Open

Splash Bottles don't extinguish flames on a player. #610

abimek opened this issue Jul 28, 2022 · 0 comments
Labels
bug Something isn't working
Milestone
v0.10.0

Comments

@abimek
Copy link
Contributor

abimek commented Jul 28, 2022

Since we don't currently check to see if a splashbottle extinguishes a player, ones feature/campfire is merged we can use the Splashable interface and implement it on player or any underlying type to extinguish it.
@JustTalDevelops JustTalDevelops added the bug Something isn't working label Jul 29, 2022
@JustTalDevelops JustTalDevelops added this to the v0.9.0 milestone Aug 1, 2022
@DaPigGuy DaPigGuy modified the milestones: v0.9.0, v0.10.0 Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
3 participants
@DaPigGuy @JustTalDevelops @abimek