Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for removing XUIDs from player lists #635

Open
Xd-pro opened this issue Aug 10, 2022 · 6 comments
Open

Option for removing XUIDs from player lists #635

Xd-pro opened this issue Aug 10, 2022 · 6 comments
Labels
improvement Improvement of an existing part of the codebase
Milestone

Comments

@Xd-pro
Copy link
Contributor

Xd-pro commented Aug 10, 2022

This makes it impossible for players to check for nicknames through the player list and disables reporting which some servers may want.

@Sandertv
Copy link
Member

I'm pretty sure first of all that this is associated with the XUID, not UUID. Sending invalid values for this would probably break things. I'm not sure this is worth implementing.

@Xd-pro
Copy link
Contributor Author

Xd-pro commented Aug 10, 2022

In gohpertunnel:

type PlayerListEntry struct {
	// UUID is the UUID of the player as sent in the Login packet when the client joined the server. It must
	// match this UUID exactly for the correct XBOX Live icon to show up in the list.
	UUID uuid.UUID```

@Xd-pro
Copy link
Contributor Author

Xd-pro commented Aug 10, 2022

Without this, clicking a player with an edited display name in the pause menu would reveal their original name, since it comes from XBL. Hell for content creators.

@Sandertv
Copy link
Member

Hell for content creators? Could you elaborate?

@Xd-pro
Copy link
Contributor Author

Xd-pro commented Aug 10, 2022

The server can change the name here:
image
But can't change the name here:
image
This makes it super easy to check if a player is nicknamed to avoid targeting.

@Xd-pro
Copy link
Contributor Author

Xd-pro commented Aug 10, 2022

Just tested this out, yes, it is the XUID that needs to be removed not the UUID. It just displays like an offline mode player.
image

@Xd-pro Xd-pro changed the title Option for sending an incorrect/invalid UUID for player list entries Option for removing XUIDs from player lists Aug 10, 2022
@JustTalDevelops JustTalDevelops added the improvement Improvement of an existing part of the codebase label Aug 11, 2022
@Sandertv Sandertv added this to the v? milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of an existing part of the codebase
Projects
None yet
Development

No branches or pull requests

3 participants