-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Area cloud effect does not behave like vanilla #665
Comments
Where did you get this from? The duration is always set to 30 seconds.
|
Yeah, I don't think this issue is valid — the logic seems to match up with the PR you linked. Is there anything in specific that is incorrect based off of vanilla, aside from the duration (which also is correct by the looks of it)? |
Did you play-tested it? dragonfly_area_effect_cloud_duration.mp4 |
This information is obtained through play-tests and analysis of the NBT in vanilla. |
About duration after debugging I found that the problem was on the client side, because it requires certain metadata to calculate the radius itself. AREA_EFFECT_CLOUD_RADIUS => (float) Initial radius
AREA_EFFECT_CLOUD_SPAWN_TIME => (int) world time when it spawned
AREA_EFFECT_CLOUD_RADIUS_PER_TICK => (float) radiusGrowth
AREA_EFFECT_CLOUD_RADIUS_CHANGE_ON_PICKUP => (float) radiusOnUse
AREA_EFFECT_CLOUD_PICKUP_COUNT => (int) Times it has been pick up (It is likely that their names do not match because they were obtained from pocketmine) |
I believe a lot of this can actually be avoided @IvanCraft623 by disabling the client-side behaviour of the cloud. Geyser does this, actually - see https://github.com/GeyserMC/Geyser/blob/3d66d2790f3a03ca8bafa7ce1cc6429ad9ab7a18/core/src/main/java/org/geysermc/geyser/entity/type/AreaEffectCloudEntity.java#L53. |
Eg: In this implementation the cloud lasts only about 15 seconds, when in fact it should last about 30 seconds.
I have described some of these behaviors in:
pmmp/PocketMine-MP#5276 (comment)
The text was updated successfully, but these errors were encountered: