Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom items looking so big #799

Open
lightyisreal opened this issue Jul 2, 2023 · 3 comments
Open

Fix custom items looking so big #799

lightyisreal opened this issue Jul 2, 2023 · 3 comments

Comments

@lightyisreal
Copy link
Contributor

The only reason I can come up with that the items are too big when holding them is because render offsets aren't properly set for the item. I'd say render offsets should be able to be controlled with a RenderOffset() method that returns the correct render offset for the item. For example, if we want to create a new sword, we should be able to use render offsets of a Minecraft sword.
The workaround I use: I have to create attachables, animations and render controllers for each custom item as they don't show up properly without them.

Maybe there's already a fix which I didn't notice at all, but that doesn't seem the case, at least for me.

@lightyisreal
Copy link
Contributor Author

This happens only in first person by the way, not in third person IIRC. The calculateItemScale method could be the issue custom items are big in first person. Why are the correct base values used only when the item's HandEquipped() method returns true?

@lightyisreal
Copy link
Contributor Author

lightyisreal commented Jul 5, 2023

After some research, I found out attachables are the way to go. Render offsets won't make it out of experiments, so it's just better to create attachables for each custom item.

@lightyisreal lightyisreal changed the title Fix item render offsets Fix custom items looking so big Aug 21, 2023
@lightyisreal
Copy link
Contributor Author

Render offsets have been deprecated in 1.20.10+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant