Required fields Google News #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkurz Can you approve this pull request and make a new release? The current GoogleNewsSitemap is outdated and therefore useless. |
|
I will have a look but I am very very busy right now. Maybe send me a reminder in like two weeks or so. |
berjanjonker
suggested changes
May 23, 2018
There was a problem hiding this comment.
@TomWalbers Can you revert the changes in pom.xml?
All other files looks fine.
Can you approve this pull request and make a new release? |
|
@berjanjonker I hope I will find time soon for this pull request, sorry I am very busy right now. |
|
Fixed via 1ceac7f |
|
Version 1.1.0 containing this fix should be available in a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation, there are some more required fields.
I added a couple of those fields.
Documentation I based myself on: https://support.google.com/news/publisher/answer/74288?hl=en