Fix resolveConflicts function #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update .mods of clientChange instead of the clientChange object itself. When resolving server and client UPDATEs we tried to remove the keyPath from the clientChange object when there was a conflicting path instead of the clientChange.mods object. Similarly we tried to remove nested keyPaths which were in conflict from the clientChange object instead of its .mods object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update .mods of clientChange instead of the clientChange object itself.
When resolving server and client UPDATEs we tried to remove the keyPath
from the clientChange object when there was a conflicting path instead of the
clientChange.mods object.
Similarly we tried to remove nested keyPaths which were in conflict from
the clientChange object instead of its .mods object.