Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First, Awesome Code! / Issues with the new Chrome version 66 / Video auto play without sound not working #186

Open
gera3d opened this issue May 7, 2018 · 3 comments

Comments

@gera3d
Copy link

gera3d commented May 7, 2018

Description

Briefly describe the issue.
Hi, Thank for creating such an awesome piece of code. I have been rocking it on all our sites for over a year with zero issues. More recently with chromes anti-auto play stuff, it seems like this code may have gotten caught in the crossfire.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Go to https://www.nioralsurgery.com/
  2. Just watch the video load and pause on the first frame

You can see the same result on a few of our sites. Built the same way. They all stopped working together.
https://amarillooralsurgery.com
https://www.mtstateoms.com/
https://nalortho.com/

Results

Expected

The video to keep playing over and over

Actual

Currently, it's just passing on the first frame. You can see what I want it to look like if you click on any page off the homepage then click the homepage link to get back to the homepage.

Error output

video.min.js?ver=5.0.2:16 Uncaught (in promise) DOMException: The play() request was interrupted by a new load request.

This seems to be acting as though my video has audio when it does not.

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

what version of videojs does this occur with?
5.0.2

browsers

Chrome

OSes

Current version os OSX

plugins

Nope

@gera3d
Copy link
Author

gera3d commented May 7, 2018

Ok fixed it by adding muted="muted" to the video element and it fixed the issue =D.

@coolmanlume
Copy link

Hi @gera3d,
Could you elaborate: where do you add this parameter to fix the issue?
I have the same problem.
Thanks.

@atomjack
Copy link

FWIW, I fixed this by editing bigvideo.js and changing line 264 from

player = $('<video id="'+vidEl.substr(1)+'" class="video-js vjs-default-skin" height="1" width="1" preload="auto" data-setup="{}" '+autoPlayString+' webkit-playsinline></video>');

to

player = $('<video id="'+vidEl.substr(1)+'" muted="muted" class="video-js vjs-default-skin" height="1" width="1" preload="auto" data-setup="{}" '+autoPlayString+' webkit-playsinline></video>');

(which is what I think @gera3d was referring to)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants