Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve update-ic.yml to handle no changes #584

Closed
peterpeterparker opened this issue Mar 25, 2024 · 3 comments
Closed

Improve update-ic.yml to handle no changes #584

peterpeterparker opened this issue Mar 25, 2024 · 3 comments

Comments

@peterpeterparker
Copy link
Member

Features

If no changes are detected, the CI job update-ic.yml should not update the comment within the did file, that way there are less noise in the provided PR.

Example

Such a comment should not be updated if no changes.

// Generated from IC repo commit 04775a0 (2024-03-21 tags: release-2024-03-20_23-01-p2p) 'rs/rosetta-api/icp_ledger/index/index.did' by import-candid

@dskloetd
Copy link
Collaborator

I think it should be updated. That way we can see the file was up-to-date at that date. Otherwise it might look like a file is very stale while it's not.

@peterpeterparker
Copy link
Member Author

It's one way to look at it, but I see it the other way around: the goal of the job is to identify new features and help us process them without creating additional overhead while limiting maintenance work.

@dskloetd
Copy link
Collaborator

Maybe if none of the files have updates, we can not do any updates. But if any of the files have updates, we update all of them to the new date/version. That way we have a minimal number of PRs but we still are mostly up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants