Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

refactor!: remove principal #25

Merged
merged 5 commits into from Sep 28, 2022
Merged

refactor!: remove principal #25

merged 5 commits into from Sep 28, 2022

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Sep 28, 2022 •
edited

We believe candid is a better place for Principal. It makes dependency management easier.
The relevant PR for candid is: dfinity/candid#378

ic-types now only has hash_tree module.

@lwshang lwshang marked this pull request as ready for review September 28, 2022 00:06
@lwshang lwshang requested a review from a team as a code owner September 28, 2022 00:06
@chenyan-dfinity
Copy link

We can also move hash_tree back to ic-agent, and deprecate the whole ic-types

@lwshang lwshang merged commit 7fecbb1 into main Sep 28, 2022
@lwshang lwshang deleted the lwshang/rm_principal branch September 28, 2022 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sesi200 sesi200 sesi200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lwshang @chenyan-dfinity @sesi200