Skip to content

Commit

Permalink
Merge branch 'tim/implement-get-all' into 'master'
Browse files Browse the repository at this point in the history
fix: implement get_all_validated_by_filter for all clients

In the future each client has p2p instance that is generic. On startup each instance calls `get_all_validated_by_filter` to populate itself. Since the component is generic it should work for all clients. 

See merge request dfinity-lab/public/ic!15682
  • Loading branch information
tthebst committed Nov 1, 2023
2 parents 5459270 + d169478 commit 25b42af
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion rs/artifact_pool/src/canister_http_pool.rs
Expand Up @@ -177,7 +177,7 @@ impl ValidatedPoolReader<CanisterHttpArtifact> for CanisterHttpPoolImpl {
&self,
_filter: &(),
) -> Box<dyn Iterator<Item = CanisterHttpResponseShare> + '_> {
unimplemented!()
Box::new(std::iter::empty())
}
}

Expand Down
2 changes: 1 addition & 1 deletion rs/artifact_pool/src/dkg_pool.rs
Expand Up @@ -154,7 +154,7 @@ impl ValidatedPoolReader<DkgArtifact> for DkgPoolImpl {
}

fn get_all_validated_by_filter(&self, _filter: &()) -> Box<dyn Iterator<Item = dkg::Message>> {
unimplemented!()
Box::new(std::iter::empty())
}
}

Expand Down
2 changes: 1 addition & 1 deletion rs/artifact_pool/src/ecdsa_pool.rs
Expand Up @@ -468,7 +468,7 @@ impl ValidatedPoolReader<EcdsaArtifact> for EcdsaPoolImpl {
}

fn get_all_validated_by_filter(&self, _filter: &()) -> Box<dyn Iterator<Item = EcdsaMessage>> {
unimplemented!()
Box::new(std::iter::empty())
}
}

Expand Down

0 comments on commit 25b42af

Please sign in to comment.