Skip to content

Commit

Permalink
[hotfix]chore: Query Cache: Revert max expiry time to be below 5 min
Browse files Browse the repository at this point in the history
  • Loading branch information
@dfinity-berestovskyy
dfinity-berestovskyy committed Feb 1, 2024
1 parent 36c9903 commit 3253f9d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rs/config/src/execution_environment.rs
View file
Expand Up @@ -101,7 +101,7 @@ const QUERY_SCHEDULING_TIME_SLICE_PER_CANISTER: Duration = Duration::from_millis
const QUERY_CACHE_CAPACITY: NumBytes = NumBytes::new(200 * MIB);

/// The upper limit on how long the cache entry stays valid in the query cache.
const QUERY_CACHE_MAX_EXPIRY_TIME: Duration = Duration::from_secs(600);
const QUERY_CACHE_MAX_EXPIRY_TIME: Duration = Duration::from_secs(290);

/// Length of an epoch of query statistics in blocks
pub const QUERY_STATS_EPOCH_LENGTH: u64 = 1800;
Expand Down

2 comments on commit 3253f9d

@ilbertt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfinity-berestovskyy what's the reason of this revert?

@dfinity-berestovskyy
Copy link
Member Author

@dfinity-berestovskyy dfinity-berestovskyy commented on 3253f9d Feb 11, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTTP gateway protocol limits the validity of the certificate to 5 min, so to go beyond that we need to track the ic0.data_certificate_copy() System API call. The tracking was also implemented in this release.

Usually we provide more details in the merge commits, i.e. see: b94ef5a and 60e04e7

Please sign in to comment.