Chore(ICSUP-3808): Improve HostOS console logging during registration

dfinity · Mar 14, 2024 · 541a311 · 541a311
1 parent ea79d85
commit 541a311
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/rs/orchestrator/src/registration.rs b/rs/orchestrator/src/registration.rs
@@ -135,6 +135,8 @@ impl NodeRegistration {
         let add_node_payload = self.assemble_add_node_message().await;
 
         while !self.is_node_registered().await {
+            warn!(self.log, "Node registration failed. Trying again.");
+            UtilityCommand::notify_host("Node registration failed. Trying again.", 1);
             match self.signer.get() {
                 Ok(signer) => {
                     let nns_url = self
@@ -543,9 +545,10 @@ impl NodeRegistration {
         {
             Ok(_) => true,
             Err(e) => {
-                warn!(
-                    self.log,
-                    "Node keys are not setup at version {}: {:?}", latest_version, e
+                warn!(self.log, "Node keys are not setup: {:?}", e);
+                UtilityCommand::notify_host(
+                    format!("Node keys are not setup: {:?}", e).as_str(),
+                    1,
                 );
                 false
             }

diff --git a/rs/orchestrator/src/signer.rs b/rs/orchestrator/src/signer.rs
@@ -35,7 +35,6 @@ impl Signer for Hsm {
     }
 }
 
-/// Signer for https://dfinity.atlassian.net/browse/NODE-439
 pub struct NodeProviderSigner {
     keypair: Secp256k1KeyPair,
 }